audio icon indicating copy to clipboard operation
audio copied to clipboard

[ROCm] Rework LoadHIP.cmake to be based purely on CMAKE_PREFIX_PATH.

Open jammm opened this issue 6 months ago • 2 comments

  • Eliminates dependence on /opt/rocm and path based heuristics.
  • Normalizes package finding for Rocm 6.5+ layout.
  • Workaround cmake >= 4.0 for hiprtc

This will help with windows support. I understand that audio is in a maintenance phase, but I highly recommend this to be merged in order to allow torchaudio to be built on for AMD systems on Windows.

Technically, this still doesn't really compile the CUDA kernels because USE_ROCM doesn't include some of those .cu files. But it still does allow building the wheels and getting things functionally running.

jammm avatar Jun 26 '25 05:06 jammm

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3945

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Jun 26 '25 05:06 pytorch-bot[bot]

This would probably be nice to have, though I don't think it is strictly required right now, at least when building 'pytorch' and 'audio' together. I minimally just needed https://github.com/pytorch/audio/pull/3991 to build with ROCm on Windows.

ScottTodd avatar Jul 24 '25 21:07 ScottTodd