pytorch
Add skip condition to vggish_pipeline_test test
Add skip condition to vggish_pipeline_test test similar to https://github.com/pytorch/audio/blob/main/test/torchaudio_unittest/backend/dispatcher/ffmpeg/save_test.py#L166 if ffmpeg executable is not found
Tested on both rocm and nvidia
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3929
- :page_facing_up: Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
This comment was automatically generated by Dr. CI and updates every 15 minutes.
![pytorch-bot[bot] avatar](https://avatars.githubusercontent.com/in/40112?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @amd-sriram!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thanks for the PR @amd-sriram . Unfortunately I don't think we'll be able to merge most incoming PRs. We're in the process of a large re-factoring of torchaudio (https://github.com/pytorch/audio/issues/3902) and a lot of functionality will be deprecated. During that time, we won't be able to prioritize fixes or improvements, sorry.
@NicolasHug : When would the refactoring of torch audio be completed ? is there a tentative date by when it will be completed and we can revisit these PRs again ?