ao icon indicating copy to clipboard operation
ao copied to clipboard

Use unittest instead of pytest everywhere

Open jerryzh168 opened this issue 1 year ago • 4 comments

fbcode is deprecating pytest support so we want to use unittest everywhere to make sure the features are tested in both OSS and fbcode

jerryzh168 avatar Nov 21 '24 21:11 jerryzh168

Hello @jerryzh168,

I am seeing the usage of both unittest and pytest in the tests now. Is the pytest still the preferred testing library?

If so maybe i can open a PR to migrate all the currently pytest tests. Currently this library uses both these tests.

osbm avatar Jan 25 '25 13:01 osbm

@osbm unittest will be preferred since pytest is deprecated in fbcode. yeah feel free to open a PR to migrate the pytest tests to use unittest, you can also start with just migrating one file before applying the changes to more files I think.

jerryzh168 avatar Jan 25 '25 21:01 jerryzh168

cc @drisspg any thoughts here?

jcaip avatar Mar 19 '25 19:03 jcaip

not particularly, I dont think pytest has broken that much internally since we have relatively vanilla usage, if someone did a full swap sure seems like BE project for a motivated individual

drisspg avatar Mar 19 '25 21:03 drisspg