TensorRT icon indicating copy to clipboard operation
TensorRT copied to clipboard
verified publisher icon pytorch

support native int64 as valid datatype

Open apbose opened this issue 1 year ago • 3 comments

apbose avatar Jun 18 '24 22:06 apbose

It seems that https://github.com/pytorch/TensorRT/pull/2855/files#diff-97c67f0cea25ec7aa88ca61594d9ad62e9fb575cab3647b079cb718f81308454 is already planned to do relevant changes.

HolyWu avatar Jun 26 '24 12:06 HolyWu

Thanks @HolyWu for pointing out the above. @narendasan would the changes in PR https://github.com/pytorch/TensorRT/pull/2855/files#diff-97c67f0cea25ec7aa88ca61594d9ad62e9fb575cab3647b079cb718f81308454 work or would we have to create a type map for kINT32 to kINT64 in the torchscript path?

apbose avatar Jun 26 '24 17:06 apbose

Yeah neither of these PRs implements the feature fully since we need to either amend truncation in TorchScript or have a TorchScript specific type map

narendasan avatar Jun 26 '24 21:06 narendasan

@apbose going to close this. reopen a new pr with the comprehensive changes if its still needed

narendasan avatar Aug 21 '24 15:08 narendasan