PiPPy icon indicating copy to clipboard operation
PiPPy copied to clipboard

Published 20 hours ago • verified publisher icon pytorch

Unify argument parsing across tests and examples to avoid code duplication

Open pbelevich opened this issue 3 years ago • 3 comments

Subtask of https://github.com/pytorch/PiPPy/issues/299

pbelevich avatar Aug 18 '22 14:08 pbelevich

Hi @pbelevich!

I would love to address this issue if possible. Will it be enough to simply create a default parser with a similar set of arguments and put it to the utils, for example? Thanks!

acforvs avatar Dec 07 '22 20:12 acforvs

Yes, please! You are so much welcome to pull a PR!

kwen2501 avatar Dec 07 '22 20:12 kwen2501

Hi @kwen2501,

I made a PR, signed the agreement, but the bot doesn't seem to recognise it. Could you take a look please?

upd: everything's ok now

acforvs avatar Dec 08 '22 14:12 acforvs