PiPPy icon indicating copy to clipboard operation
PiPPy copied to clipboard

Published 20 hours ago • verified publisher icon pytorch

Make RemoteInterpreter use the full implementation of `Interpreter.run`

Open jamesr66a opened this issue 3 years ago • 2 comments

https://github.com/jamesr66a/PiPPy/blob/527af1fd8123d35bd81b9fe304a8d0ed29c9fd8d/pippy/PipelineDriver.py#L565

I wrote run_until as a hack, it should probably be a copy-paste of Interpreter.run with some termination branch inside (or we should refactor Interpreter.run to make implementing like this easier

jamesr66a avatar Feb 16 '22 22:02 jamesr66a

More logic: https://github.com/pytorch/pytorch/blob/80f6d2e9e66a0d133a24863e6338f4c3a493e2fc/torch/fx/interpreter.py#L129

jamesr66a avatar Jul 12 '22 21:07 jamesr66a

Hi, is this still open? I am a first time good contributor

brandonidas avatar May 30 '23 15:05 brandonidas