PiPPy icon indicating copy to clipboard operation
PiPPy copied to clipboard

Use non-strict mode by default

Open kwen2501 opened this issue 9 months ago • 1 comments

torch.export has strict mode and non-strict mode. For difference, please read Non-Strict Export.

This PR switches to non-strict mode by default. Improving tracing success rate (no Dynamo graph break).

kwen2501 avatar May 02 '24 20:05 kwen2501

im not convinced.

i should be easy to convince since at the moment i'm fighting with tracer issue after tracer issue.

however, if the answer is "turn off safety so it doesn't throw errors" i'm not sure i want to use the tracer at all.

wconstab avatar May 03 '24 20:05 wconstab