FBGEMM icon indicating copy to clipboard operation
FBGEMM copied to clipboard

Updated asmjit & adapted to its latest changes

Open kobalicek opened this issue 3 months ago • 2 comments

  • Updated asmjit, which uses a different coding style
  • Modified code that used SSE versions of some vector instructions instead of AVX versions (conversion, moves, scalar operations)
  • Modified code that relied on Xmm/Ymm/Zmm to simply use Asmjit's x86::Vec operand in places where possible (requires more future work to remove the FBGEMMs Xmm/Ymm/Zmm substitutes)
  • Simplified code paths that were using avx2 and avx512
  • Simplified the use of a JitRuntime - ideally there should be only one around to reduce the number of memory mappings, so now there is only one shared JitRuntime - it doesn't need a lock as it's thread-safe

kobalicek avatar Nov 15 '25 15:11 kobalicek

Hi @kobalicek!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

meta-cla[bot] avatar Nov 15 '25 15:11 meta-cla[bot]

Take it or dump it - it was just a little exercise for me to understand how much time is required per project to adapt to the new version of AsmJit. The rest of the changes are related to a correct use of AsmJit and a correct use of instructions in AVX/AVX-512 mode.

kobalicek avatar Nov 15 '25 15:11 kobalicek