FBGEMM icon indicating copy to clipboard operation
FBGEMM copied to clipboard

Gen modes: Remove `-Wno-mismatched-tags`

Open q10 opened this issue 7 months ago • 2 comments

Summary:

  • Is it even possible to be more thorough? #buildall - Be so, so thorough #buildmore - Be thorough #buildsonlynotests - No runtime effects!
  • If you approve of this diff, please use the "Accept & Ship" button ig-no-test - Doesn't require Instagram testing. allow-large-files
  • If you approve of this diff, please use the "Accept & Ship" button :-)

Please avoid revert. 3,000+ diffs were landed testing parts of this change. This change also underwent extensive CI testing (see above). Reverting invalidates large pieces of the RE cache and is likely much more expensive than fixing the few problems this diff is likely to surface. I apologize for any inconvenience: I'm doing my best with the infrastructure available to me and doing my best to improve that infrastructure also.

Reviewed By: q10

Differential Revision: D73536513

q10 avatar Apr 23 '25 20:04 q10

This pull request was exported from Phabricator. Differential Revision: D73536513

facebook-github-bot avatar Apr 23 '25 20:04 facebook-github-bot

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
Latest commit f9d183301c6338ce14f7245846685a682b8d7bde
Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/6809516014f4d4000870287c
Deploy Preview https://deploy-preview-4011--pytorch-fbgemm-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 23 '25 20:04 netlify[bot]