FBGEMM icon indicating copy to clipboard operation
FBGEMM copied to clipboard

Published 20 hours ago • verified publisher icon pytorch

Remove unused variables in deeplearning/fbgemm/fbgemm_gpu/codegen/embedding_forward_split_cpu.cpp

Open r-barnes opened this issue 1 year ago • 2 comments

Summary: LLVM-15 has a warning -Wunused-but-set-variable which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with [[maybe_unused]], mostly in cases where the variable is used, but, eg, in an assert statement that isn't present in production code.

  • If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: sryap

Differential Revision: D54378367

r-barnes avatar Mar 08 '24 14:03 r-barnes

This pull request was exported from Phabricator. Differential Revision: D54378367

facebook-github-bot avatar Mar 08 '24 14:03 facebook-github-bot

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
Latest commit 3aeb9aab189576961b304e1229a8e1b2b7598db9
Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/65eb1b3e69805400083939d1
Deploy Preview https://deploy-preview-2403--pytorch-fbgemm-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 08 '24 14:03 netlify[bot]