FBGEMM icon indicating copy to clipboard operation
FBGEMM copied to clipboard

Pass cache stats to TBE only when using LRU

Open sryap opened this issue 1 year ago • 3 comments

Summary: This diff introduces a condition to pass local_uvm_cache_stats to TBE only when using the LRU policy.

When local_uvm_cache_stats is passed to TBE, it utilizes the cache unique conflict misses information to determine whether to load data entirely or partially from cache, UVM, or HBM. If this information is inaccurate, TBE may produce an incorrect output. Since the unique conflict misses stat is only collected during the cache lookup only when the LRU cache eviction policy is used, local_uvm_cache_stats should not be passed to TBE when other cache eviction policies are used.

Differential Revision: D54237731

sryap avatar Feb 27 '24 08:02 sryap

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
Latest commit 38adf108798025c88359f6ebbe1862cc661e1261
Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/65dd9a91a95b750008b5271b
Deploy Preview https://deploy-preview-2359--pytorch-fbgemm-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 27 '24 08:02 netlify[bot]

This pull request was exported from Phabricator. Differential Revision: D54237731

facebook-github-bot avatar Feb 27 '24 08:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D54237731

facebook-github-bot avatar Feb 27 '24 08:02 facebook-github-bot