FBGEMM icon indicating copy to clipboard operation
FBGEMM copied to clipboard

bug fix for CPU pruned weighted TBE

Open jspark1105 opened this issue 1 year ago • 3 comments

Summary: When we see a pruned row we also need to skip the corresponding weight. D36461772 fixed EmbeddingSpMDMNBit.cc but didn't EmbeddingSpMDM.cc

Added unit tests for both 8bit and Nbit cases. Fixed random number generations in unit tests that were generating deterministic random numbers.

Differential Revision: D54163836

jspark1105 avatar Feb 25 '24 04:02 jspark1105

This pull request was exported from Phabricator. Differential Revision: D54163836

facebook-github-bot avatar Feb 25 '24 04:02 facebook-github-bot

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
Latest commit 0609c6419a3675d9c4a6777383be0aa64ffffa03
Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/65dac3ca132a3a0008ac5d09
Deploy Preview https://deploy-preview-2352--pytorch-fbgemm-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 25 '24 04:02 netlify[bot]

This pull request was exported from Phabricator. Differential Revision: D54163836

facebook-github-bot avatar Feb 25 '24 04:02 facebook-github-bot

Hi @jspark1105!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Nov 16 '24 02:11 facebook-github-bot