FBGEMM icon indicating copy to clipboard operation
FBGEMM copied to clipboard

Pipelined-hip embeddingBag forward.

Open liligwu opened this issue 3 years ago • 2 comments

The credits of the pipelined-hip implementation belong to @carlushuang.

liligwu avatar Sep 01 '22 00:09 liligwu

Deploy Preview for eclectic-stroopwafel-199537 canceled.

Name Link
Latest commit 8c38e2bcb8e1b4745c6ec6a61ea778da1aced27d
Latest deploy log https://app.netlify.com/sites/eclectic-stroopwafel-199537/deploys/63101076edf3e000097442bd

netlify[bot] avatar Sep 01 '22 00:09 netlify[bot]

Note, we keep AMD optimal kernel for embeddings as separate module (fbgemm_gpu/hip_kernel) is to facilitate:

  • vendor innovation with a degree of freedom to drop-in the very best and very latest
  • the kernels there will be HIP native, no need to hipify different than code in codegen
  • functionality and performance prove Acknowledge that kernel code here is yet to be beautified, coding style and naming convention are neither similar.

HaiShaw avatar Sep 01 '22 02:09 HaiShaw