gpt-fast icon indicating copy to clipboard operation
gpt-fast copied to clipboard

added presets for mistral7b

Open alvion427 opened this issue 1 year ago • 5 comments

  • option to specify name of model on command line

alvion427 avatar Dec 20 '23 13:12 alvion427

Hi @alvion427!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Dec 20 '23 13:12 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Dec 20 '23 14:12 facebook-github-bot

Could you remove the model_name modification? Nothing against it in particular, but since this repo doesn't have any CI set up and I'm currently unable to test these repos - it's a bit hard to validate correctness from only reviewing code PRs.

I'm happy to merge the mistral change.

Chillee avatar Dec 21 '23 03:12 Chillee

cool, i finally got around to this!

On Thu, Dec 21, 2023 at 3:36 AM Horace He @.***> wrote:

Could you remove the model_name modification? Nothing against it in particular, but since this repo doesn't have any CI set up and I'm currently unable to test these repos - it's a bit hard to validate correctness from only reviewing code PRs.

I'm happy to merge the mistral change.

— Reply to this email directly, view it on GitHub https://github.com/pytorch-labs/gpt-fast/pull/63#issuecomment-1865428884, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQDRFGWMRUXQTEMIAGMS2DYKOVD7AVCNFSM6AAAAABA42KNVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRVGQZDQOBYGQ . You are receiving this because you were mentioned.Message ID: @.***>

alvion427 avatar Dec 24 '23 13:12 alvion427

Subscribed. would love to see this get merged!

binarycrayon avatar Feb 06 '24 23:02 binarycrayon