junction icon indicating copy to clipboard operation
junction copied to clipboard

Remove python 2 unicode compatible

Open sks444 opened this issue 5 years ago • 7 comments

Closes https://github.com/pythonindia/junction/issues/666

sks444 avatar Apr 10 '20 16:04 sks444

Coverage Status

Coverage decreased (-0.3%) to 66.917% when pulling 2926b0138d4bd1bbdb328a95fd158d560a99c5fa on sks444:remove-python_2_unicode_compatible into 49af450e177904c5edeced57154425b2a5e40040 on pythonindia:master.

coveralls avatar Apr 10 '20 16:04 coveralls

Do your thing Travis CI.

pradyunsg avatar Apr 15 '20 11:04 pradyunsg

Does anyone have concerns with this?

pradyunsg avatar May 07 '20 10:05 pradyunsg

Note: Putting a hold on the merge until the upgrade compatibility is tested

palnabarun avatar May 07 '20 11:05 palnabarun

@sks444 This is a good to go change for Python 3. Thank you! :slightly_smiling_face:

palnabarun avatar May 07 '20 11:05 palnabarun

@sks444 Can you rebase the changes ?

ananyo2012 avatar Jun 07 '20 15:06 ananyo2012

@sks444 -- can you please rebase the changes against master?

palnabarun avatar Jun 07 '20 18:06 palnabarun