Added command to export reviewer's votes

[the-xperimentalist]

Fix for: https://github.com/pythonindia/junction/issues/553

[coveralls]

Coverage decreased (-0.05%) to 67.308% when pulling b3470b5c16001c88fc9657e847c12b11e8a541a2 on prasoonmayank:master into b8309fbfcc7c33a5edb772ee3a485ceb27da6f39 on pythonindia:master.

[palnabarun]

@prasoonmayank Left some comments.

Also, please lint your code before committing. You can do so by running nox -s lint

[the-xperimentalist]

Will be completing proper testing with corner cases by today

[sks444]

@prasoonmayank, It looks like you have committed your env file?

[ananyo2012]

@prasoonmayank Can you rebase your changes and run the linter again. There is a recent PR that has been merged with a change in the linting approach.

[the-xperimentalist]

Hey @ananyo2012 is there a way to run the lint code without nox? Since, earlier, nox was calling a flake8 command, and was able to lint it. Since, for some reason, nox is not working in Mac

[pradyunsg]

@prasoonmayank Why is nox not working for you? Could you share the error message?

[pradyunsg]

Also, yes, you can run the linters without nox, by running pre-commit directly (pip install pre-commit and then pre-commit run --all-files).

[ananyo2012]

I will try to run the latest linting changes locally. We also got a report earlier regarding issues running test locally.

On Sun, Apr 5, 2020 at 2:39 AM Pradyun Gedam [email protected] wrote:

Also, yes, you can run the linters without nox, by running pre-commit directly (pip install pre-commit and then pre-commit run --all-files).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[the-xperimentalist]

@prasoonmayank Why is nox not working for you? Could you share the error message?

There were essentially two problems in my case:

1. pipx wasn't installing nox.
2. For some reason, nox command in Mac was setup in a different folder, since there are multiple python versions installed probably?
3. Regarding linting, with the latest changes, we are able to lint with the pre-commit command only with the python version being 3.6

[ananyo2012]

@prasoonmayank There is an issue reported for Mac systems in #660 . What python versions do you have in your system ? Instead of using nox can you try running tests using pytest --cov -v --tb=native.

pre-commit should be able to lint in all versions. Are you seeing any failures related to isort ? That's a known issue introduced recently. Except that other linting tests should work.

[the-xperimentalist]

#660

I installed python3.6 for the pre-commit linter to work. Regarding the test coverage. All the test cases have been passing, but the build is failing for some reason. Can you suggest some probable reason for the same?

[pradyunsg]

@prasoonmayank If you click details on the failing check, you can see the CI runs, and then clicking on the specific job reveals the output of that job.

In this case, the linters are failing for you.

[ananyo2012]

The isort fails are a valid one I mentioned in #663 cc: @pradyunsg

[pradyunsg]

Hey @prasoonmayank, could you file an issue describing why you aren't able to install nox (including the error messages if you see any)? If it's not working for a contributor, that's a bug in either our developer tools, or developer documentation. :)

[pradyunsg]

Other than that, please feel free to go ahead and merge master into this PR / rebase this PR on master.

[sayanchowdhury]

Before merging please make sure the commits are squashed.

[the-xperimentalist]

Hey @palnabarun Please review the pr. As it is in requested changes state right now

[aniruddha2000]

@mpras97 are you still working on this?

[the-xperimentalist]

@mpras97 are you still working on this?

Yes. Willl resolve these comments