junction icon indicating copy to clipboard operation
junction copied to clipboard

Create a management code to export reviewers vote

Open kracekumar opened this issue 6 years ago • 11 comments

The functionality is available here https://github.com/pythonindia/junction/blob/e8cefd7910f807873a9f0d7650f6868ccffbeac0/junction/proposals/dashboard.py#L287. You need to create a command line version.

kracekumar avatar Nov 03 '17 06:11 kracekumar

Hey @kracekumar, I would like to work on it. Can I?

areyohrahul avatar Dec 03 '17 14:12 areyohrahul

@rahulxxarora Please go ahead.

kracekumar avatar Dec 04 '17 06:12 kracekumar

@kracekumar @palnabarun This seems fun, I can take a stab at it. A little guidance is appreciated.

djb4ai avatar Mar 21 '20 05:03 djb4ai

So, this requires you to create a management command for Django, which would take in the conference slug as an argument, call the above-mentioned function and return you the reviewer votes for every proposal submitted for that conference.

References https://docs.djangoproject.com/en/1.8/howto/custom-management-commands/ https://docs.djangoproject.com/en/3.0/howto/custom-management-commands/

We are currently running on Django 1.9 so the Django documentation may be a bit tough to navigate

palnabarun avatar Mar 21 '20 05:03 palnabarun

@palnabarun I thought the issue had something to do with argparse or click, not very good with django if anybody else wanna take it, go-ahead.

djb4ai avatar Mar 21 '20 06:03 djb4ai

@lladhibhutall If you want to tackle a click+argparse+optparse issue, I suggest you take a look at pip's issue related to its CLI: https://github.com/pypa/pip/issues/ 4659.

pradyunsg avatar Mar 21 '20 07:03 pradyunsg

I would like to work on this issue

aniruddha2000 avatar Jul 30 '20 15:07 aniruddha2000

I wrote some code by reading the django documntation. But the test saying python 2.7 tests are success but python 3.6 is failed. @palnabarun can you review the code. Should I open a PR?

aniruddha2000 avatar Jul 30 '20 17:07 aniruddha2000

@aniruddha2000 -- #650 was raised to solve this. Maybe you should have a look there?

palnabarun avatar Jul 30 '20 17:07 palnabarun

@aniruddha2000 -- #650 was raised to solve this. Maybe you should have a look there?

yes but in #650 the code that the guy wrote that for create a csv file as well as storing the data right? But storing data functionality is already done in the below section right? https://github.com/pythonindia/junction/blob/e8cefd7910f807873a9f0d7650f6868ccffbeac0/junction/proposals/dashboard.py#L287 So I have to create a command that create a csv file and then it call the above function and it will write into the csv file right?

aniruddha2000 avatar Aug 01 '20 16:08 aniruddha2000

To anyone reading this after the https://github.com/pythonindia/junction/issues/553#issuecomment-602000342

So, this requires you to create a management command for Django, which would take in the conference slug as an argument, call the above-mentioned function and return you the reviewer votes for every proposal submitted for that conference.

This call the above-mentioned function is not correct. A function has to be written which has a similar behavior and not use the above-mentioned function.

palnabarun avatar Aug 03 '20 15:08 palnabarun