junction icon indicating copy to clipboard operation
junction copied to clipboard

Auto detect URL in the proposal and highlight

Open kracekumar opened this issue 7 years ago • 7 comments

When a user misses using markdown syntax to highlight the URL in the proposal section, automatically highlight the URL in the text.

URL: https://in.pycon.org/cfp/2017/proposals/pytorch-for-the-tensorflow-developers-and-others-dl-enthusiasts~dLApe/

url_missing_highlight

kracekumar avatar Jul 06 '17 13:07 kracekumar

In the above description, I didn't use Markdown syntax, still, GH highlights the URL.

kracekumar avatar Jul 06 '17 13:07 kracekumar

Taking this up

mish24 avatar Aug 20 '17 15:08 mish24

@mish24 Please go ahead.

kracekumar avatar Aug 20 '17 16:08 kracekumar

@kracekumar mostly in content_urls there's the need to use angular brackets to identify multiple URLs and convert them. This won't recognize any link if it's already inside any block of code. Basically I was going to implement simple regex scraping for storing urls here. Shall I go ahead? In my opinion telling the users to use angular brackets seems like a much better option. What are your thoughts?

mish24 avatar Aug 20 '17 22:08 mish24

@mish24 Giving heads up the field supports the markdown is an excellent option. The form field should auto detect URLs and add respective markup. I'm sure the existing Markdown Field or another plugin can do this. Can you look around?

kracekumar avatar Aug 26 '17 18:08 kracekumar

Yeah. I'll upgrade to django-markdown2 and write some filters. That'll do it. Sending PR soon

mish24 avatar Aug 27 '17 13:08 mish24

This seemed to work fine until 408f0c0 removed the 'linkify' markdown extension, any reason why that was done?

smtchahal avatar Jan 07 '18 14:01 smtchahal