inpycon2019 icon indicating copy to clipboard operation
inpycon2019 copied to clipboard

Published 20 hours ago • verified publisher icon pythonindia

Modified maplink

Open anujaagarwal opened this issue 6 years ago • 5 comments
trafficstars

anujaagarwal avatar Aug 09 '19 14:08 anujaagarwal

Why are there unrelated commits in the PR?

astronomersiva avatar Aug 10 '19 02:08 astronomersiva

Because of unrelated commits, I made a separate branch and pushed new changes but again it is including unnecessary commits .

On Sat, 10 Aug 2019, 07:38 Sivasubramanyam A, [email protected] wrote:

Why are there unrelated commits in the PR?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pythonindia/inpycon2019/pull/140?email_source=notifications&email_token=AF7AJA67KPA33YCJHOVE4WTQDYPLRA5CNFSM4IKU2UT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4AD35Y#issuecomment-520109559, or mute the thread https://github.com/notifications/unsubscribe-auth/AF7AJAYNEEFE7HYT37HS3WLQDYPLRANCNFSM4IKU2UTQ .

anujaagarwal avatar Aug 10 '19 04:08 anujaagarwal

@anujaagarwal, I would recommend reading up on how to use Git and GitHub. Please remove the unrelated commits from both PRs.

astronomersiva avatar Aug 10 '19 05:08 astronomersiva

Okay, noted!

anujaagarwal avatar Aug 10 '19 05:08 anujaagarwal

I tried doing git rebase -i HEAD~n command to drop commits but by doing that my changes become unchanged, it again comes to previous mode. Review my PR from next time i will push my commit accordingly.

anujaagarwal avatar Aug 10 '19 14:08 anujaagarwal