inpycon2017 icon indicating copy to clipboard operation
inpycon2017 copied to clipboard

Update : Command for python 3 added

Open Shivang-Bhandari opened this issue 8 years ago • 7 comments

Updated the command to run the project locally using Python 3

Shivang-Bhandari avatar Jul 21 '17 05:07 Shivang-Bhandari

@akshayaurora would be great if you could take a look.

Shivang-Bhandari avatar Jul 21 '17 17:07 Shivang-Bhandari

@Shivang-Bhandari please specify the python version you are using. I deployed your fix and running staticjinja on Python 3.5.2 (other versions might also) is throwing error while importing easywatch which is a currently an open issue with a temporary solution. It's better to go with the solution which works i.e. Python 2 in this case.

realslimshanky avatar Jul 21 '17 20:07 realslimshanky

@realslimshanky Python 3.6.0 If you feel we should stick to Python 2 then it's not a problem.

Shivang-Bhandari avatar Jul 22 '17 14:07 Shivang-Bhandari

@Shivang-Bhandari If you have tested it on 3.6.0 specifically do mention in the README about it. Because other versions might fail to run the script.

realslimshanky avatar Jul 23 '17 22:07 realslimshanky

@realslimshanky sure

Shivang-Bhandari avatar Jul 24 '17 04:07 Shivang-Bhandari

@SanketDG would you like to have another look after the update?

realslimshanky avatar Oct 20 '17 15:10 realslimshanky

@realslimshanky LGTM

SanketDG avatar Oct 20 '17 19:10 SanketDG