ComfyUI-Custom-Scripts icon indicating copy to clipboard operation
ComfyUI-Custom-Scripts copied to clipboard

ShowText Node is no longer displaying text.

Open lord-lethris opened this issue 1 year ago • 8 comments

Updated ComfyUI, and now the ShowText Node is no longer displaying text.

workflow (23)

It is however passing text though.

workflow (24)

Its just not showing the text in the ShowText Node's Display like it use to anymore.

lord-lethris avatar Sep 29 '24 03:09 lord-lethris

Hi, I've been having the same problem. I investigated and debugged a bit, and here is a few pointers: If you are using DeepFuze custom node, there seem to be a conflict as stated here On the frontend side, when ShowText is done receiving input to display, it goes into nodeType.prototype.onExecuted from showText.js. This executes:

onExecuted?.apply(this, arguments);
populate.call(this, message.text);

The first line seems to wrongly trigger their function from DeepFuze's preview_audio.js

nodeType.prototype.onExecuted = function (data) {
    previewAudio(this, data.audio[0], data.audio[1]);
}

Which results in an error (as we aren't trying to preview audio or anything, the data value passed is null). When such errors occur, I think comfyUI handles it by using a break, which stops the execution, thus not displaying the text through populate.call.

Possible solutions

  • Users having this problem can try uninstalling the DeepFuze custom node, assuming they aren't using it in the same workflow. This did it for me. I think there is a way to declare a conflict somehow, it could be useful to avoid this.
  • Switching the order of calls in the code seems to do it (still result in an error on DeepFuze's end, but after updating the text in ShowText node), these line 44 and 45 from showText.js would become :
	populate.call(this, message.text);
	onExecuted?.apply(this, arguments);

-> Would there be any side effect to switching the order to that? What is the goal of onExecuted?.apply(this, arguments);in ShowText's context?

  • I guess fixing DeepFuze to filter properly what is received on their end, like handling the case where data is null or not usable for their purposes would do it.

Hope it helps!

Beatboxace avatar Sep 29 '24 21:09 Beatboxace

That has indeed helped. you are a star Mr @Beatboxace

I hope DeepFuze gets a fix for it then.

DeepFuze has caused a number of issues with users I see, their requirement file uninstalls newer dependencies and replaces them with MUCH older ones.

Even me, personally, I had to re-install ONNX, Torch and XFormers after DeepFuze ballsed them up.

Or... We just stop using DeepFuze :(

lord-lethris avatar Sep 30 '24 08:09 lord-lethris

I have same issue even I didn't installed the DeepFuze

Yanquansu avatar Oct 10 '24 16:10 Yanquansu

I have this same issue and don't have DeepFuze installed. I hope the dev can fix it. Does anyone know of any other nodes that have the same functionality?

Xenodimensional avatar Nov 15 '24 01:11 Xenodimensional

hello! Your letter I have received, thanks!

Yanquansu avatar Nov 15 '24 01:11 Yanquansu

Please Pythongosssss, a lot of people, workflows and nodes depend on this one!

Xenodimensional avatar Dec 02 '24 11:12 Xenodimensional

Hi, I've been having the same problem. I investigated and debugged a bit, and here is a few pointers: If you are using DeepFuze custom node, there seem to be a conflict as stated here On the frontend side, when ShowText is done receiving input to display, it goes into nodeType.prototype.onExecuted from showText.js. This executes:

onExecuted?.apply(this, arguments);
populate.call(this, message.text);

The first line seems to wrongly trigger their function from DeepFuze's preview_audio.js

nodeType.prototype.onExecuted = function (data) {
    previewAudio(this, data.audio[0], data.audio[1]);
}

Which results in an error (as we aren't trying to preview audio or anything, the data value passed is null). When such errors occur, I think comfyUI handles it by using a break, which stops the execution, thus not displaying the text through populate.call.

Possible solutions

  • Users having this problem can try uninstalling the DeepFuze custom node, assuming they aren't using it in the same workflow. This did it for me. I think there is a way to declare a conflict somehow, it could be useful to avoid this.
  • Switching the order of calls in the code seems to do it (still result in an error on DeepFuze's end, but after updating the text in ShowText node), these line 44 and 45 from showText.js would become :
	populate.call(this, message.text);
	onExecuted?.apply(this, arguments);

-> Would there be any side effect to switching the order to that? What is the goal of onExecuted?.apply(this, arguments);in ShowText's context?

  • I guess fixing DeepFuze to filter properly what is received on their end, like handling the case where data is null or not usable for their purposes would do it.

Hope it helps!

Wonderful. Thanks a lot dear. I worked.

AISTUDIO80 avatar Jan 09 '25 19:01 AISTUDIO80

hello! Your letter I have received, thanks!

Yanquansu avatar Jan 09 '25 19:01 Yanquansu