ComfyUI-Custom-Scripts icon indicating copy to clipboard operation
ComfyUI-Custom-Scripts copied to clipboard

Update imageFeed.js

Open tachyon-beep opened this issue 1 year ago • 2 comments

This is a (somewhat over the top) rewrite of the Image Feed system based on my previous abandoned pull request.

The feed:

  • lets the user filter images based on source node.
  • groups images from the same run into batches with a visible marker.

Additionally, the slider for height as well as two new controls have been moved to the ComfyUI menu.

Locking the feed to the left or right has not yet been implemented but I can readd it if its a 'must go' feature. Known 'image nodes' are defined in an array, with unrecognised nodes caught via a catch fall filter setting. I'm currently looking for a better way to identify 'image' nodes for inclusion in the filter.

Tested on Firefox and Chromium.

tachyon-beep avatar Mar 31 '24 05:03 tachyon-beep

The big weakness of this implementation is that I haven't found a way to dynamically identify 'image' nodes. There's a 'custom node' fallback, but this is deeply unsatisfying.

All feedback is welcome, but feedback on that issue specifically is extra welcome.

tachyon-beep avatar Mar 31 '24 05:03 tachyon-beep

Hey, thanks, would you please be able to split the different parts into their own PRs (probably: batch markers, filtering nodes, ui refactor changes), as its difficult to review with everything all in one.

For some early feedback:

  • Since ComfyUI is shared across multiple extensions + core for CSS variables, could you either uniquely prefix the variables or move them from :root, you should also use the standard ComfyUI variables so it matches the users theme.
  • You can identify nodes that currently have images by checking if node.imgs is set, you can't know if a node might have an image
  • I frequently resize the feed/columns depending on which monitor + image resolution i'm generating, so I wouldn't be happy to have to go to settings to change this each time
  • Left & right would be required
  • I can't scroll the image feed anymore in Firefox

pythongosssss avatar Apr 07 '24 14:04 pythongosssss