ComfyUI-Custom-Scripts icon indicating copy to clipboard operation
ComfyUI-Custom-Scripts copied to clipboard

Feature Request: Have "View Info..." Tool Utilize Existing A1111 JSON Files

Open camoody1 opened this issue 1 year ago • 4 comments

I love the "View Info..." tool that you've added to the Checkpoint Loader and Lora Loader. They are very helpful for finding the correct models. One request I would ask, however, is if you could allow this tool to utilize any existing .jpg or .png preview already downloaded for the model in question. I.E. In Automatic1111, I have an extension installed called "Stable-Diffusion-Webui-Civitai-Helper" that downloads all the model information from Civitai and saves it locally to the appropriate model folder for each model. It saves a .json file with a lot of great model information, as well as a preview image in the format "modelname.preview.png". If you could allow your tool to use these existing files, it would greatly improve the speed of the pop-up information window.

Thank you for your consideration.

camoody1 avatar Dec 21 '23 21:12 camoody1

That should already be supported: https://github.com/pythongosssss/ComfyUI-Custom-Scripts/issues/37

image Here it is loading .preview.png

pythongosssss avatar Jan 03 '24 18:01 pythongosssss

Outstanding. I see that your node is looking for those preview images. I apologize for not realizing that.

Aside from the image, there's a lot of great information stored in the json file that this extension writes. Maybe you could make use of that, as well. Though, I noticed that your node saves some other type of file for each model I lookup information on.

Regardless, this is a GREAT step forward for usability in ComfyUI. The functionality is something I feel like the core nodes should utilize, also.

camoody1 avatar Jan 04 '24 00:01 camoody1

Outstanding. I see that your node is looking for those preview images. I apologize for not realizing that.

Aside from the image, there's a lot of great information stored in the json file that this extension writes. Maybe you could make use of that, as well. Though, I noticed that your node saves some other type of file for each model I lookup information on.

Regardless, this is a GREAT step forward for usability in ComfyUI. The functionality is something I feel like the core nodes should utilize, also.

I'd also like if the existing info in the A1111 JSON would be loaded. Maybe edit the title of the issue to reflect this?

A1111 saves info like this:

loras
| `- <loraname>.safetensors
| `- <loraname>.json

The JSON looks like this:

{
    "description": "",
    "sd version": "SD1",
    "activation text": "",
    "preferred weight": 0,
    "notes": ""
}

xieve avatar Jan 14 '24 13:01 xieve

If this can be a thing it would be wonderful. I am using ComfyUI automatic1111 extension and I can't seem to get your 'view info' to recognize the existing civitai helper plugin info.

Ainaemaet avatar Jan 27 '24 02:01 Ainaemaet