Review performance impact of `Sprite.scale` changes

Open einarf opened this issue 1 year ago • 1 comments

This might just be about reverting https://github.com/pythonarcade/arcade/pull/2021

The vector sprite perf testing showed 2.x cost. We should quickly review the cost of the sprite scale changes before we release.

https://github.com/pythonarcade/arcade/blob/fa6e9387cb9801081f378a4b4e978028ea531bd8/arcade/sprite/base.py#L263-L339

We might just have to revert these changes for now and bake them into the new experimental sprites. See : https://github.com/pythonarcade/arcade/issues/2184

Jul 28 '24 14:07 einarf

Considering scale returns a Vec2 this should be part of the vector sprites later in 3.1/3.2

Aug 03 '24 18:08 einarf

https://github.com/pythonarcade/arcade/pull/2389

Oct 07 '24 00:10 einarf

Pending review

Oct 08 '24 21:10 einarf