arcade icon indicating copy to clipboard operation
arcade copied to clipboard

./make.py format does not auto-fix all formatting issues

Open pushfoo opened this issue 1 year ago • 0 comments

Bug Report

Actual behavior:

./make.py format doesn't aply ruff import auto-fixes

Expected behavior:

./make.py format also runs ruff's auto-fixes for formats

Steps to reproduce/example code:

  1. I ran ./make.py format
  2. CI reports that the black formatting issues were fixed, but stale imports were left behind:
Run python ./make.py ruff
arcade/draw/line.py:4:42: F401 [*] `arcade.types.Point` imported but unused
  |
3 | from arcade import gl
4 | from arcade.types import RGBA255, Color, Point, Point2List
  |                                          ^^^^^ F401
5 | from arcade.window_commands import get_window
  |
  = help: Remove unused import: `arcade.types.Point`

Found 1 error.
[*] 1 fixable with the `--fix` option.
Error: Process completed with exit code 1.

pushfoo avatar Jul 05 '24 14:07 pushfoo