arcade icon indicating copy to clipboard operation
arcade copied to clipboard

Remove mention of pyglet's PulseAudio bug

Open pushfoo opened this issue 2 years ago • 1 comments

Changes

Remove mention of a PulseAudio bug which seems to be fixed as of upgrading arcade to use pyglet 2.0.10 (#1930).

To be reasonably sure this is the correct change to make, we may want to hold off on merging this until https://github.com/pyglet/pyglet/pull/1017 is approved and merged.

pushfoo avatar Dec 15 '23 22:12 pushfoo

I've marked this as a draft for now since the PulseAudio fixes didn't actually make it into pyglet's 2.0.10 release.

pushfoo avatar Dec 16 '23 03:12 pushfoo

Wait for pyglet to release 2.0.11 and bump required version within arcade

eruvanos avatar Feb 27 '24 21:02 eruvanos

Update on this:

  1. We aren't ready to merge yet because pyglet hasn't released 2.0.11
  2. We're close because pyglet/203c5b6 is labeled as getting ready for that release

pushfoo avatar Feb 27 '24 21:02 pushfoo

Pyglet's out.

DigiDuncan avatar Feb 28 '24 05:02 DigiDuncan

I fixed the build failures. They were due to pyglet.layout.TextLayout appending _anchor to its _get_* anchor methods in 2.0.11.

~~The build failures may be related to 2.0.11's changes to pyglet's Label class or its dependencies. I'm investigating.~~

pushfoo avatar Feb 28 '24 06:02 pushfoo

Left, right, bottom, top properties exist on the TextLayouts themselves now (as of 2.0.11). You should use those instead as the anchors no longer factor in the position of the layout.

caffeinepills avatar Feb 28 '24 16:02 caffeinepills