typing_extensions icon indicating copy to clipboard operation
typing_extensions copied to clipboard

Test Python 3.14 in CI

Open srittau opened this issue 8 months ago • 6 comments

srittau avatar Apr 01 '25 12:04 srittau

Ideally I'd want to use something like continue-on-error: ${{ matrix.python-version == '3.14-dev' }}, but I don't think it's possible. (We could of course emulate this by changing the shell command, but I don't like that.)

srittau avatar Apr 01 '25 12:04 srittau

but I don't think it's possible.

I think it might be? I saw something similar in the SQLAlchemy tests: https://github.com/sqlalchemy/sqlalchemy/blob/main/.github/workflows/run-test.yaml#L121

brianschubert avatar Apr 01 '25 12:04 brianschubert

Huh, I tried that but VSCode flagged that as invalid and the GitHub docs didn't mention it. I'll change it.

srittau avatar Apr 01 '25 12:04 srittau

Can/should we add a warning in a failing case?

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-a-warning-message

Daraan avatar Apr 02 '25 07:04 Daraan

In principle I like the idea of a warning message, but I didn't want to complicate the CI scripts for now.

srittau avatar Apr 02 '25 09:04 srittau

Can/should we add a warning in a failing case?

I think we get this for free - it seems an error annotation still gets emitted for the failing step even when the job doesn't fail: https://github.com/python/typing_extensions/actions/runs/14196009731

brianschubert avatar Apr 02 '25 16:04 brianschubert

All commit authors signed the Contributor License Agreement.

CLA signed

python-cla-bot[bot] avatar Apr 06 '25 13:04 python-cla-bot[bot]

Working on a PR to make the 3.14 tests pass

JelleZijlstra avatar May 05 '25 14:05 JelleZijlstra