typeshed icon indicating copy to clipboard operation
typeshed copied to clipboard

Remove emoji stubs (not before ?)

Open kkirsche opened this issue 2 years ago • 1 comments

With https://github.com/carpedm20/emoji/pull/166 merged using the stubs previously contributed to typeshed, the ~~latest release now~~ next release should include type hints. Seems 2.1.0 was tagged directly before type hints being merged.

kkirsche avatar Sep 17 '22 21:09 kkirsche

As per our policy, we'll want to wait until the library has shipped with a py.typed file for at least six months before removing the stubs from typeshed, but this is great to hear! :)

AlexWaygood avatar Sep 17 '22 23:09 AlexWaygood

Emoji 2.1.0 was released on September 17, 2022.

https://pypi.org/project/emoji/2.1.0/

When in front of a computer, I'll confirm that it has the py.typed marker. If so, this should give us a date for when this should be removed.

I'll plan to file a separate issue for automated py.typed detection to gauge interest in this type of automation / integration.

kkirsche avatar Oct 12 '22 17:10 kkirsche

I'll plan to file a separate issue for automated py.typed detection to gauge interest in this type of automation / integration.

Stubsabot already does that for us (see, e.g., #8746). If there's already been an emoji release that has a py.typed file, that indicates that there's a bug in stubsabot.

AlexWaygood avatar Oct 12 '22 17:10 AlexWaygood

There doesn't appear to be a bug in stubsabot. The master branch has the py.typed marker, but the latest release, 2.1.0, released on September 17, does not have the py.typed marker.

AlexWaygood avatar Oct 12 '22 17:10 AlexWaygood

Probably a bug in emoji packaging

hauntsaninja avatar Oct 12 '22 17:10 hauntsaninja

It is a bug in emoji. The py.typed marker isn't added to the package https://github.com/carpedm20/emoji/pull/239

Avasam avatar Oct 14 '22 18:10 Avasam

We now have a release with a py.typed file!

  • #9051

AlexWaygood avatar Nov 01 '22 00:11 AlexWaygood