typeshed
typeshed copied to clipboard
python
Additional return types for psycopg2 connections
Adds correct return types for DB connection and cursor methods that deal with namedtuple and dict-like cursors. Currently the types are either incomplete (e.g. the connections' cursor methods do not specify return types) or wrong (e.g. DictCursor's fetch* methods should not return tuples, which is currently inherited from DictCursorBase).
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I'm not sure of the best approach to solving the mypy errors in CI. The cases where it is reporting that an override's return types are incompatible with the super return types are how it is actually implemented in the underlying library's code (i.e. the stubs I've added merely reflect the reality of the code). Thoughts?
Stubs should reflect what the library actually does. We use # type: ignore[override] to silence type checker errors in situations like this.
All right. I have made several changes, including adding # type: ignore for the incompatible return types. I believe this PR is ready for review now.