typeshed icon indicating copy to clipboard operation
typeshed copied to clipboard

[stubsabot] Bump stripe to 4.0.*

Open github-actions[bot] opened this issue 2 years ago • 4 comments

Release: https://pypi.org/project/stripe/4.0.2/ Homepage: https://github.com/stripe/stripe-python Changelog: https://github.com/stripe/stripe-python/blob/master/CHANGELOG.md

If stubtest fails for this PR:

  • Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
  • Fix stubtest failures in another PR, then close this PR

github-actions[bot] avatar Aug 05 '22 00:08 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Aug 05 '22 00:08 github-actions[bot]

Looks like our stripe stubs need a fair few updates -- @kkirsche, is this something you might be interested in helping out with? :)

AlexWaygood avatar Aug 05 '22 13:08 AlexWaygood

I'll need to take a look at the library to see if it's one that I'd be a good fit for updating. I can certainly handle parts of it, but want to make sure I'm not biting off more than I can chew.

I found the v4 migration guide which may be of use from https://github.com/stripe/stripe-python/releases: https://github.com/stripe/stripe-python/wiki/Migration-guide-for-v4

It seems they were still iterating rather quickly with 4.0.0 just coming out to clean up release bugs, so it may be a good fit to tackle next week as it stabilizes

kkirsche avatar Aug 05 '22 13:08 kkirsche

If it's not for you, that's fine :)

You can see a comparison of the 3.5 and 4.2 releases here: https://github.com/stripe/stripe-python/compare/v3.5.0...v4.0.2

AlexWaygood avatar Aug 05 '22 13:08 AlexWaygood

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Oct 05 '22 18:10 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Oct 06 '22 00:10 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Oct 31 '22 00:10 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Nov 17 '22 00:11 github-actions[bot]

FWIW, stripe-python have been adding annotations and completing types recently https://github.com/stripe/stripe-python/pulls?q=is%3Apr+sort%3Aupdated-desc+is%3Aclosed+type And seem to plan to ship py.typed soon https://github.com/stripe/stripe-python/pull/1074/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7

Related feature request: https://github.com/stripe/stripe-python/issues/650

Typeshed is so far behind, it might just not be worth the update.

Avasam avatar Oct 14 '23 16:10 Avasam