typeshed icon indicating copy to clipboard operation
typeshed copied to clipboard

`paramiko`: Change dependencies on `types-cryptography`, allow using upstream type hints

Open intgr opened this issue 4 years ago • 4 comments

Since version 3.4, the cryptography library itself ships with type hints: https://cryptography.io/en/latest/changelog/#v3-4

This is the first step for #5618. Currently, if I use types-paramiko and cryptography, it forces me to use types-cryptography as well. It should be up to the end-user to decide if they want upstream hints or from typeshed.

As discussed in #5618 and #5768, I have replaced it with a dependency on types-paramiko -> cryptography and types-pyOpenSSL -> cryptography.

intgr avatar Aug 05 '21 13:08 intgr

Ping @srittau?

intgr avatar Aug 11 '21 13:08 intgr

This needs a bit more infrastructure work in typeshed. Currently, our tests don't install the dependencies from METADATA.toml, meaning that the tests could fail due to changes in cryptography. I will try to work on this soon.

srittau avatar Aug 11 '21 14:08 srittau

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar May 07 '22 10:05 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Jul 11 '22 12:07 github-actions[bot]

Fixed in #9459. Thanks @intgr, and sorry that this took so long!

AlexWaygood avatar Jan 10 '23 22:01 AlexWaygood

Thanks! Better late than never 😆

intgr avatar Jan 11 '23 10:01 intgr