typeshed icon indicating copy to clipboard operation
typeshed copied to clipboard
verified publisher icon python

update GDB stubs to 16.3

Open oltolm opened this issue 7 months ago • 8 comments

oltolm avatar May 02 '25 22:05 oltolm

Diff from mypy_primer, showing the effect of this PR on open source code:

pwndbg (https://github.com/pwndbg/pwndbg)
+ pwndbg/dbg/gdb/symbol.py:162: error: Unused "type: ignore" comment  [unused-ignore]

github-actions[bot] avatar May 02 '25 22:05 github-actions[bot]

Diff from mypy_primer, showing the effect of this PR on open source code:

pwndbg (https://github.com/pwndbg/pwndbg)
+ pwndbg/dbg/gdb/symbol.py:162: error: Unused "type: ignore" comment  [unused-ignore]

github-actions[bot] avatar May 02 '25 23:05 github-actions[bot]

Diff from mypy_primer, showing the effect of this PR on open source code:

pwndbg (https://github.com/pwndbg/pwndbg)
+ pwndbg/dbg/gdb/symbol.py:162: error: Unused "type: ignore" comment  [unused-ignore]

github-actions[bot] avatar May 03 '25 10:05 github-actions[bot]

Thanks! stubs/gdb/METADATA.toml needs to be updated to the correct version as well. Also, for review purposes, is there some way to view the changes to the Python API between the versions?

srittau avatar May 05 '25 13:05 srittau

You can look at NEWS and search for * Python API.

oltolm avatar May 10 '25 10:05 oltolm

Diff from mypy_primer, showing the effect of this PR on open source code:

pwndbg (https://github.com/pwndbg/pwndbg)
+ pwndbg/dbg/gdb/symbol.py:162: error: Unused "type: ignore" comment  [unused-ignore]

github-actions[bot] avatar May 10 '25 10:05 github-actions[bot]

Diff from mypy_primer, showing the effect of this PR on open source code:

pwndbg (https://github.com/pwndbg/pwndbg)
+ pwndbg/dbg/gdb/symbol.py:162: error: Unused "type: ignore" comment  [unused-ignore]

github-actions[bot] avatar May 29 '25 12:05 github-actions[bot]

@oltolm Our CI still complains about a few symbols that are not available at runtime: https://github.com/python/typeshed/actions/runs/15323229467/job/43111418230?pr=13923

Are you sure these items exist in gdb 16.3? In that case, these items need to be added to stubs/gdb/@tests/stubtest_allowlist.txt, otherwise they need to be removed from the stubs.

srittau avatar May 30 '25 14:05 srittau

Just for reference: it's generally best to avoid force-pushing, since that makes it hard for reviewers to see what change. We squash all commits when merging anyway

brianschubert avatar Aug 09 '25 13:08 brianschubert

Diff from mypy_primer, showing the effect of this PR on open source code:

pwndbg (https://github.com/pwndbg/pwndbg)
+ pwndbg/dbg/gdb/symbol.py:162: error: Unused "type: ignore" comment  [unused-ignore]

github-actions[bot] avatar Aug 09 '25 13:08 github-actions[bot]

Diff from mypy_primer, showing the effect of this PR on open source code:

pwndbg (https://github.com/pwndbg/pwndbg)
+ pwndbg/dbg/gdb/symbol.py:162: error: Unused "type: ignore" comment  [unused-ignore]

github-actions[bot] avatar Aug 09 '25 13:08 github-actions[bot]