python
Improve PyMySQL stubs
Diff from mypy_primer, showing the effect of this PR on open source code:
ibis (https://github.com/ibis-project/ibis)
- ibis/backends/mysql/datatypes.py:27: error: Module "pymysql.connections" has no attribute "TEXT_TYPES" [attr-defined]
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
In the code, this TEXT_TYPES value is https://github.com/PyMySQL/PyMySQL/blob/95635f587ba9076e71a223b113efb08ac34a361d/pymysql/connections.py#L49
Diff from mypy_primer, showing the effect of this PR on open source code:
ibis (https://github.com/ibis-project/ibis)
- ibis/backends/mysql/datatypes.py:27: error: Module "pymysql.connections" has no attribute "TEXT_TYPES" [attr-defined]
Diff from mypy_primer, showing the effect of this PR on open source code:
ibis (https://github.com/ibis-project/ibis)
- ibis/backends/mysql/datatypes.py:27: error: Module "pymysql.connections" has no attribute "TEXT_TYPES" [attr-defined]
Diff from mypy_primer, showing the effect of this PR on open source code:
ibis (https://github.com/ibis-project/ibis)
- ibis/backends/mysql/datatypes.py:27: error: Module "pymysql.connections" has no attribute "TEXT_TYPES" [attr-defined]
Thanks. I've noticed that you included a few private functions and methods in the stubs. Do you need them? We usually only include private items when they are explicitly requested.
No, I don't need them, I just want to start actively contributing to this project, because I'm interested in typing.
Diff from mypy_primer, showing the effect of this PR on open source code:
ibis (https://github.com/ibis-project/ibis)
- ibis/backends/mysql/datatypes.py:27: error: Module "pymysql.connections" has no attribute "TEXT_TYPES" [attr-defined]
No, I don't need them, I just want to start actively contributing to this project, because I'm interested in typing.
Ok, could you remove them for now? This makes the stubs more succinct, easier to maintain and doesn't rely on undocumented internals.
No, I don't need them, I just want to start actively contributing to this project, because I'm interested in typing.
Ok, could you remove them for now? This makes the stubs more succinct, easier to maintain and doesn't rely on undocumented internals.
Alright, I'll get right on it! Thank you for your assistance!
Diff from mypy_primer, showing the effect of this PR on open source code:
ibis (https://github.com/ibis-project/ibis)
- ibis/backends/mysql/datatypes.py:27: error: Module "pymysql.connections" has no attribute "TEXT_TYPES" [attr-defined]