typeshed icon indicating copy to clipboard operation
typeshed copied to clipboard

move re.error into re.pyi

Open tungol opened this issue 1 year ago • 3 comments

implementation is in sre_constants / re._constants, but it sets it's __module__ to re

tungol avatar Dec 20 '23 00:12 tungol

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Dec 20 '23 00:12 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Dec 20 '23 18:12 github-actions[bot]

I'm making this a draft pending discussion in https://github.com/python/typeshed/issues/11141

I'm inclined to think using an explicit __module__ attribute (like runtime does) is a better way to handle this discrepancy.

tungol avatar Dec 23 '23 05:12 tungol