pythondotorg icon indicating copy to clipboard operation
pythondotorg copied to clipboard

fix(#1701): Events page displays year for events scheduled to start or end at a future year

Open alvindera97 opened this issue 1 year ago • 2 comments

What

  • Addition of event year text to events page (for events scheduled with any date not in the current year.
  • Replaces https://github.com/python/pythondotorg/pull/1714.

Closes

  • Fixes https://github.com/python/pythondotorg/issues/1701.

alvindera97 avatar Aug 08 '24 06:08 alvindera97

Good day everyone, I hope you're all doing well.

I initially worked on this issue (#1701) some time ago, and it was opened in 2020. The problem involved events with start or end dates that are not in the current year (i.e. not matching datetime.datetime.now().year on the server). These events were displayed without indicating the year, which could cause confusion for users.

While event names often include the year, displaying the year directly with the event dates on the frontend provides additional clarity and improves user experience by avoiding any ambiguity.

If possible, I'd appreciate a review of my pull request. I’m happy to answer any questions you may have and will do my best to clarify any details.

Thank you for your time, and I look forward to your feedback.

Best regards,
Godwin

alvindera97 avatar Aug 28 '24 21:08 alvindera97

After reviewing some other pull requests on the repo, I decided that adding screenshots of before and after would better give a visual summary of what has been done

Before:

Screenshot from 2024-09-15 17-01-50

After:

Screenshot from 2024-09-15 16-57-00

alvindera97 avatar Sep 15 '24 16:09 alvindera97

Thanks for your continued contributions, @alvindera97! Very much appreciated :)

JacobCoffee avatar Sep 26 '24 21:09 JacobCoffee