pythondotorg icon indicating copy to clipboard operation
pythondotorg copied to clipboard

fix(frontend): Improve low constrast of code blocks and links

Open tomasr8 opened this issue 1 year ago • 3 comments

Closes #2446

I changed the code block color for the closest darker green that surpasses 4.5 - Firefox is now reporting it as 4.57.

I didn't want to change the link color for all links, so I just added a new rule to target links in tables only. Firefox now reports the new value as 4.56.

Let me know if it's ok like this!

tomasr8 avatar Jul 25 '24 19:07 tomasr8

I only checked the green so far, looks better.

Before:

image

After:

image

You know, I might be tempted to drop that rounded grey background box altogether, we don't have that sort of thing at https://docs.python.org/3/whatsnew/3.12.html, or keep the grey background but drop the shadow and rounder border radius.

image image

(Possibly also ditching the green?)

image image

hugovk avatar Jul 25 '24 21:07 hugovk

Could also decrease the padding.. It looks pretty big

tomasr8 avatar Jul 26 '24 08:07 tomasr8

I think I like this the best out of the options:

image

but the current "After:" state is good, too.

JacobCoffee avatar Sep 12 '24 23:09 JacobCoffee

Looks like we forgot about this PR :)

I think I like this the best out of the options:

image

Yeah, let's ditch all padding/margin/background/box stuff.

@tomasr8 Please could you update to remove that too?

hugovk avatar Nov 07 '25 14:11 hugovk