pythondotorg icon indicating copy to clipboard operation
pythondotorg copied to clipboard

Issue #1701: Events page displays year for events scheduled to start or end at a future year

Open alvindera97 opened this issue 5 years ago • 1 comments

This is the PR replacing https://github.com/python/pythondotorg/pull/1713. The functional tests have been removed and logical/functional concerns have been replicated with unit tests that don't require selenium to run.

This is basically because of the CI Pipeline which makes no provision for installing selenium's web driver required by selenium to run the [headless] functional tests.

There is something that I would like to note: — When I was running the unit tests, I found out that Django was somehow caching the results of the tests and so the subsequent test results I was getting were rather untrustworthy.

• I was able to get around this by adding a tearDown() method to the relevant unit test class. This tearDown() method basically clears the cache at the end of each test (cache.clear()) suggested here

Please feel free to ask any questions. This is basically my first shot at contributing to open source software.

alvindera97 avatar Dec 27 '20 11:12 alvindera97

Good day @ewdurbin. Please could you review my pull request? Thank you.

alvindera97 avatar Jan 06 '21 15:01 alvindera97

Hi everyone 👋🏾

A very warm greeting to you all and I would like to use this opportunity to say a big thank you for keeping Python's website functional all these years! It's been a very long time since I last worked on this pull request (essentially 4 years now).. I've been able to merge/rebase all updates since that time and confirmed that the tests pass and the feature still works.

Just as a footnote, this PR resolves #1701.

Thank you for you time and I hope a favourable response :). If there's anyone who would be free to take a look at what changes have been made and how they impact the source code, please feel free to leave comments and I will be able to respond to / hopefully address your comment.

Best regards.

alvindera97 avatar Aug 08 '24 05:08 alvindera97

I'm currently working on making a cleaner version of this pull request... I'll most probably move it to another PR, however I'll mention this pull request.

alvindera97 avatar Aug 08 '24 06:08 alvindera97

I've set up the new pull request replacing this one here: https://github.com/python/pythondotorg/pull/2500... I will now be closing this pull request.

alvindera97 avatar Aug 08 '24 06:08 alvindera97