pythondotorg icon indicating copy to clipboard operation
pythondotorg copied to clipboard

Distorted Footer links and back-to-top not working for Mobile Device for Oneplus 7t

Open parasj93 opened this issue 5 years ago • 5 comments

Describe the bug The footer links is distorted on mobile devices Please refer the screenshot for reference.

Also the back to top click is not working

To Reproduce Steps to reproduce the behavior:

  1. Go to 'python.org'
  2. Click on ' enter'
  3. Scroll down to ' bottom of the page'
  4. See the distorted UX on footer links

Expected behavior UX should be consistent and back-to-top should scroll to top

Screenshots Screenshot_20200523-202515

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [Oneplus 7t]
  • OS: [Android 10]
  • Browser [e.g. Google Chrome]
  • Version[ 81.0]

Additional context Add any other context about the problem here.

parasj93 avatar May 23 '20 15:05 parasj93

Same issue on my phone. When I choose iPhone SE or iPhone 12 Pro in my browser's device toolbar, the footer looks normal. However, on some other devices like iPhone XR and Pixel 7 it looks broken.

ghost avatar Jun 11 '24 08:06 ghost

image image

JacobCoffee avatar Sep 13 '24 18:09 JacobCoffee

Thanks @hogsmead and @parasj93 , would either of you like to open a PR to resolve?

JacobCoffee avatar Sep 13 '24 18:09 JacobCoffee

Hi, @JacobCoffee I would like to take this issue.

adistrim avatar Sep 24 '24 05:09 adistrim

@adistrim Sure! Have at it :) Let me know if you need assistance

JacobCoffee avatar Sep 24 '24 14:09 JacobCoffee

is this issue resolved if not i want to resolve it

karnrautela avatar Jan 25 '25 17:01 karnrautela

@karnrautela if you are still up for it, you can submit a PR and I'll review!

JacobCoffee avatar Feb 04 '25 17:02 JacobCoffee

Yes sir

On Tue, 4 Feb, 2025, 10:59 pm Jacob Coffee, @.***> wrote:

Assigned #1591 https://github.com/python/pythondotorg/issues/1591 to @karnrautela https://github.com/karnrautela.

— Reply to this email directly, view it on GitHub https://github.com/python/pythondotorg/issues/1591#event-16182646870, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAXJQODLDY7GQEG2GRWRNZ32OD2IBAVCNFSM6AAAAABJD4CU3SVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGE4DENRUGY4DOMA . You are receiving this because you were assigned.Message ID: @.***>

karnrautela avatar Feb 05 '25 03:02 karnrautela

Can u pls guide me this is my first open source contribution

On Wed, 5 Feb, 2025, 9:16 am KARAN RAUTELA, @.***> wrote:

Yes sir

On Tue, 4 Feb, 2025, 10:59 pm Jacob Coffee, @.***> wrote:

Assigned #1591 https://github.com/python/pythondotorg/issues/1591 to @karnrautela https://github.com/karnrautela.

— Reply to this email directly, view it on GitHub https://github.com/python/pythondotorg/issues/1591#event-16182646870, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAXJQODLDY7GQEG2GRWRNZ32OD2IBAVCNFSM6AAAAABJD4CU3SVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGE4DENRUGY4DOMA . You are receiving this because you were assigned.Message ID: @.***>

karnrautela avatar Feb 05 '25 03:02 karnrautela

@karnrautela sure–

  1. You'll want to set up your dev environment (see: https://github.com/python/pythondotorg/blob/main/docs/source/install.md)
  2. Investigate some of the files that would contain the issue
  • https://github.com/python/pythondotorg/blob/4e2bd048f74878dde67cded083168ce2a17fc839/static/sass/style.scss
  • https://github.com/python/pythondotorg/blob/4e2bd048f74878dde67cded083168ce2a17fc839/templates/base.html
  • Maybe https://github.com/python/pythondotorg/blob/4e2bd048f74878dde67cded083168ce2a17fc839/static/js/script.js
  • maybe more?
  1. Probably there can be changed some SASS, but I'm not really a frontend person so I would also just be poking around until I figured it out.
  2. Test your changes in the browser with different screen sizes
  3. Submit a PR with the changes and we can review/test

JacobCoffee avatar Feb 05 '25 19:02 JacobCoffee

I'll check it out

On Thu, 6 Feb, 2025, 1:18 am Jacob Coffee, @.***> wrote:

@karnrautela https://github.com/karnrautela sure–

  1. You'll want to set up your dev environment (see: https://github.com/python/pythondotorg/blob/main/docs/source/install.md )
  2. Investigate some of the files that would contain the issue

https://github.com/python/pythondotorg/blob/4e2bd048f74878dde67cded083168ce2a17fc839/static/sass/style.scss

https://github.com/python/pythondotorg/blob/4e2bd048f74878dde67cded083168ce2a17fc839/templates/base.html

  • Maybe https://github.com/python/pythondotorg/blob/4e2bd048f74878dde67cded083168ce2a17fc839/static/js/script.js
  • maybe more?
  1. Probably there can be changed some SASS, but I'm not really a frontend person so I would also just be poking around until I figured it out.
  2. Test your changes in the browser with different screen sizes https://firefox-source-docs.mozilla.org/devtools-user/responsive_design_mode/
  3. Submit a PR with the changes and we can review/test

— Reply to this email directly, view it on GitHub https://github.com/python/pythondotorg/issues/1591#issuecomment-2637881864, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAXJQOECQ57LL53YBL4AL7D2OJTIDAVCNFSM6AAAAABJD4CU3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZXHA4DCOBWGQ . You are receiving this because you were mentioned.Message ID: @.***>

karnrautela avatar Feb 05 '25 22:02 karnrautela