pyperformance
pyperformance copied to clipboard
"upload" only works with "compiled" benchmarks
My workflow for PyPy is
- download latest version compiled on buildbot,
- run benchmarks,
- upload data (using command line option
upload, which goes throughcompile.py, but should it?.
The cmd_upload function in compile.py assumes BenchmarkRevision.update_metadata from compile.py has been run to add commit information (commit_id, commit_branch, commit_date) and possibly patch_file to the json benchmark info. But because I am not running compile this info is lacking. Possible solutions:
- add a
download_prebuiltoption tocompile.pyand thePythonclass to support this workflow - refactor the
update_metadatamethod fromBenchmarkRevisionto become part of every benchmark run
Any thoughts? Should there be an upload.py separate from compile.py?
I should be possible to upload without compiling.
+1 to this