pyperformance icon indicating copy to clipboard operation
pyperformance copied to clipboard

"upload" only works with "compiled" benchmarks

Open mattip opened this issue 7 years ago • 2 comments

My workflow for PyPy is

  1. download latest version compiled on buildbot,
  2. run benchmarks,
  3. upload data (using command line option upload, which goes through compile.py, but should it?.

The cmd_upload function in compile.py assumes BenchmarkRevision.update_metadata from compile.py has been run to add commit information (commit_id, commit_branch, commit_date) and possibly patch_file to the json benchmark info. But because I am not running compile this info is lacking. Possible solutions:

  • add a download_prebuilt option to compile.py and the Python class to support this workflow
  • refactor the update_metadata method from BenchmarkRevision to become part of every benchmark run

Any thoughts? Should there be an upload.py separate from compile.py?

mattip avatar Apr 04 '18 06:04 mattip

I should be possible to upload without compiling.

vstinner avatar May 10 '19 03:05 vstinner

+1 to this

kmod avatar Feb 25 '22 21:02 kmod