pyperformance icon indicating copy to clipboard operation
pyperformance copied to clipboard

Published 20 hours ago • verified publisher icon python

gh-202: Simplify Windows installation

Open jkloth opened this issue 2 years ago • 4 comments

PR for issue #202

jkloth avatar May 17 '22 23:05 jkloth

@gvanrossum, what do you think?

ericsnowcurrently avatar May 24 '22 17:05 ericsnowcurrently

Removing that docs section seems premature, the root cause hasn't even been fixed (seems the OP is on a quest here :-).

I'm okay with adding the env var to work around the setuptools problem, we can just remove it again (and require a high enough setuptools version) once that is fixed in setuptools. I don't think stdlib distutils is going away in 3.12 yet, is it? If it removed before setuptools fixes the bug on their side, we'd have to lean on setuptools.

gvanrossum avatar May 24 '22 20:05 gvanrossum

I wouldn't say quest but attempting to run pyperformance from a source checkout is what started this whole chain of changes. I just found it unreasonable to need to remember to do the additional setup for testing an in-progress build. So, I leveraged my Windows build system knowledge to hunt down the cause of this issue.

jkloth avatar May 25 '22 14:05 jkloth

I don't think stdlib distutils is going away in 3.12 yet, is it?

See https://github.com/python/cpython/issues/92584 (and https://peps.python.org/pep-0632), distutils is going away in 3.12. That has not happened quite yet, but probably will relatively soon.

ericsnowcurrently avatar May 25 '22 16:05 ericsnowcurrently