pyperformance icon indicating copy to clipboard operation
pyperformance copied to clipboard

Published 20 hours ago • verified publisher icon python

Add tomllib.loads benchmark

Open kumaraditya303 opened this issue 3 years ago • 7 comments

kumaraditya303 avatar May 14 '22 06:05 kumaraditya303

It seems like requires-python = ">=3.11" has no effect and seems broken.

kumaraditya303 avatar May 14 '22 07:05 kumaraditya303

We can merge this once the tests are passing. Do you know what the problem is?

ericsnowcurrently avatar Jun 10 '22 15:06 ericsnowcurrently

See https://github.com/python/pyperformance/pull/200#issuecomment-1126665696

The issue is that requires-python metadata has no effect.

kumaraditya303 avatar Jun 10 '22 16:06 kumaraditya303

Ah, right. I'll take a look at that real quick and then merge it.

ericsnowcurrently avatar Jun 10 '22 21:06 ericsnowcurrently

Maybe we should have this install toml from PyPI instead of only using the stdlib one? That would give us more Python version coverage.

mdboom avatar Jun 17 '22 16:06 mdboom

(tomllib is based on pypi's tomli, not toml)

hauntsaninja avatar Jun 17 '22 20:06 hauntsaninja

Maybe we should have this install toml from PyPI instead of only using the stdlib one? That would give us more Python version coverage.

Well, I wanted to specifically test the version in the stdlib as it would help in finding regression too. Also requires-python = ">=3.11" would need fixing even if this PR were to be changed to not use it.

kumaraditya303 avatar Jul 05 '22 13:07 kumaraditya303