peps icon indicating copy to clipboard operation
peps copied to clipboard

PEP 101 should mention bug tracker and buildbots

Open vstinner opened this issue 5 years ago • 10 comments

When master became Python 3.10 and 3.9 branch was created, we had to:

  • Update buildbot configuration:

    • https://github.com/python/buildmaster-config/commit/2e2ba06c01969bea6389d5b459eff2116b35d038
    • https://github.com/python/buildmaster-config/commit/d024d2d2aa0aafc6ac14132537e2fbc00733b0b1
    • https://github.com/python/buildmaster-config/commit/321cd924454ee28404e4b55a41c6c9b10bef71ee
  • Add 3.10 version in the bug tracker: https://bugs.python.org/version ("edit carefully")

vstinner avatar May 19 '20 15:05 vstinner

cc @pablogsal @zware @ambv

vstinner avatar May 19 '20 15:05 vstinner

Oh, it also seems like when a new branch (like 3.9) is created, we don't get all pre-commit CIs by default: see https://github.com/python/core-workflow/issues/369

vstinner avatar May 19 '20 15:05 vstinner

Assigning Barry and Guido as PEP 101 authors. A

AA-Turner avatar Jan 23 '22 00:01 AA-Turner

I don’t know enough about this topic to care anymore. :-)

Maybe this PEP needs a new owner?

gvanrossum avatar Jan 23 '22 00:01 gvanrossum

I'll admit my assigning people was half a prompt to update this issue / see if it should be closed! I've removed you now.

Perhaps the release managers should be owners? @ambv @pablogsal @ned-deily (sorry if I missed anyone!)

A

AA-Turner avatar Jan 23 '22 00:01 AA-Turner

I think someone just needs to send a PR and then we should get maybe get signoff from one of the recent release managers (Pablo, Łukasz, or Ned).

JelleZijlstra avatar Jan 23 '22 00:01 JelleZijlstra

Yes, please consult a release manager for one of the active versions of Python 😄 . In fact, I wouldn't mind if one or all of the above take over as Authors of PEP 101.

warsaw avatar Jan 23 '22 00:01 warsaw

I can take ownership of the PEP for the time being :)

@ambv do you want to join the party?

pablogsal avatar Jan 24 '22 12:01 pablogsal

Yes, please :-)

ambv avatar Jan 24 '22 12:01 ambv

As far as I can tell, the original two points @vstinner listed above are as of now at least mentioned in the PEP, as sub-bullets under the final list item, the "you will need to ensure various pieces of the development infrastructure are updated for the new branch" one:

  • If this is a new branch release, you will need to ensure various pieces of the development infrastructure are updated for the new branch. These include: * Update the issue tracker for the new branch. * Add the new version to the versions list (contact the tracker admins?). * Add a regressions keyword for the release
  • Ensure buildbots are defined for the new branch (contact zware).

Is there anything specific that should be added to them?

Adding the additional pre-commit CIs may be implied by

  • Verify that CI is working for new PRs for the main and new release branches and that the release branch is properly protected (no direct pushes, etc).

but not directly stated, so it would seem that might be worth adding.

Whoever makes the PR on this can add you two to the CODEOWNERS and remove Barry and Guido.

Do either of you want to submit that? What about @vstinner ? If you have something specific you want to add/change, one of us can try to take care of it for you and submit the PR for your review, since I'm sure you're busy people.

Thanks!

CAM-Gerlach avatar Jan 25 '22 00:01 CAM-Gerlach

As far as I can tell, the original two points @vstinner listed above are as of now at least mentioned in the PEP

Good. I consider that the issue is now fixed, I close it.

vstinner avatar Sep 06 '24 14:09 vstinner