mypy icon indicating copy to clipboard operation
mypy copied to clipboard

Support @no_type_check for classes

Open JukkaL opened this issue 10 years ago • 6 comments

This are defined in the PEP 484 draft.

JukkaL avatar Mar 21 '15 04:03 JukkaL

This is now supported for functions but not for classes.

JukkaL avatar May 17 '15 18:05 JukkaL

The title here is incorrect, the @no_type_check decorator is working for functions but @no_type_check_decorator does not appear to be implemented.

lunixbochs avatar Mar 22 '19 19:03 lunixbochs

Regarding the title, there seem to be two remaining issues.

  • @no_type_check isn't implemented for classes
  • @no_type_check_decorator isn't implemented at all

Note that the latter allows people to define their own decorators whose effect is equivalent to that of @no_type_check, i.e. this is a meta-level decorator.

AFAICT, #6584 will fix the first bullet but not the second. Perhaps we need to create a separate issue for the latter?

gvanrossum avatar Mar 22 '19 20:03 gvanrossum

OK, changed the title to reflect that this issue (#607) is about the @no_type_check decorator as applied to classes, while the new #6583 is about the "meta" decorator, @no_type_check_decorator.

gvanrossum avatar Mar 22 '19 20:03 gvanrossum

Can someone review my PR #6584?

lunixbochs avatar Jan 21 '20 17:01 lunixbochs

Linking a thread about what the semantics for no_type_check for classes should be: https://discuss.python.org/t/no-type-check-decorator/43119

There is little evidence for any user demand for this feature, so this is overall unlikely to be implemented unless you, the reader, are willing to do it.

Jelle mentions a possible semantics here: https://discuss.python.org/t/no-type-check-decorator/43119/34 Another possible semantics is basically replacing the class with class X(Any): ...

hauntsaninja avatar Feb 04 '24 06:02 hauntsaninja

FWIW re: user demand, I ran into wanting this feature which is why I'm subscribed. I wanted to be able to use the type annotation syntax for defining structs for generated code for IPC, but the types I would use wouldn't make sense to a normal type checker, and the class is only intended to be used for code generation via inspect, not actually instantiated. I think there is a chicken and egg problem where people aren't going to demonstrate use cases as long as it doesn't work. In my case I abandoned the idea because I couldn't get any of the static type checkers to cooperate and instead used kwarg syntax and rely on the fact that in newer python versions kwarg order is preserved, e.g.

mystruct = gen.Struct(
    x=gen.Int32,
    y=gen.Float64,
    # ...
)

jgarvin avatar Mar 12 '24 16:03 jgarvin