mypy
mypy copied to clipboard
Followup tasks for checkmember.py refactoring
These are some of the remaining tasks after https://github.com/python/mypy/issues/7724 is done. These are either somewhat tricky and/or somewhat boring and/or less pressing. In no particular order:
- We should cleanup/unify attribute writeability logic when checking overrides and subtyping. Most notably:
- Multiple inheritance is quite messy in this regard.
- Descriptors with custom
__set__()should follow the same logic (including use ofmutable-overrideerror code) as properties with custom setters in protocol subtyping and LSP checks.
- We need to set
type_checkerin more places to benefit from the new (complete) logic forfind_member(), most notable insemanal_typeargs.pyand in post-semanal plugins. - Now that all attribute access is going through
checkmemberwe should refactor it itself. Couple ideas:- Merge
bind_self()andcheck_self_arg() - Generalize/extend
analyze_decorator_or_funcbase_access() - Cleanup class attribute access and unify it with instance attribute access
- Merge
- We should re-think how deferrals work, and re-enable some deferrals that are currently skipped (current logic is too limited, we stop all inference after first deferral, and can't defer module scope). The new logic may be like this:
- We can defer either a module scope or a top-level function (similar to fine-grained incremental)
- Use "sticky" (i.e. propagating to nested nodes) flag to suppress
Any-related error reporting - Use new
TypeOfAnyto suppress inferring bogusAnytypes for variables - Update all
isinstance()-like checks to handle this new kind ofAny
- Cleanup
Var(and relatedRefExprandAssignmentStmt) flags. There are way too many of them, and some of them are used inconsistently. - Couple pedantic things we shouldn't even do:
- Check class level access for descriptor overrides
- Take into account
__getattr__()for LSP checks
cc @JukkaL just FYI so that you are more aware of the situation.
Hello, i was wondering if this issue was completed. I'm studying github and wanted to contribute to a open source project. If this issue it's not open, do you guys have any new refactoring issues? Thanks for the attention. Best regards, Leo Lomardo