mypy icon indicating copy to clipboard operation
mypy copied to clipboard

Consider adding new plugin API for checking implicit definitions

Open sobolevn opened this issue 2 years ago • 1 comments

Feature

This PR introduces a new check for mypy: we now can find incompatible __post_init__ methods in @dataclasses: https://github.com/python/mypy/pull/15503/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04R1048-R1050

But, the thing is that for now we are using a direct call to dataclasses internal plugin, because there are no ways to do it otherwise.

Pitch

Let's discuss possible options we have to introduce a new API that can solve this problem.

CC @ilevkivskyi (original reviewer), @Tinche (as you might be interested), @JukkaL

sobolevn avatar Jun 25 '23 10:06 sobolevn

Sounds cool. Could you keep me in the loop? I'm interested.

On Sun, Jun 25, 2023 at 12:37 PM Nikita Sobolev @.***> wrote:

Feature

This PR introduces a new check for mypy: we now can find incompatible post_init methods in @dataclasses: https://github.com/python/mypy/pull/15503/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04R1048-R1050

But, the thing is that for now we are using a direct call to dataclasses internal plugin, because there are no ways to do it otherwise.

Pitch

Let's discuss possible options we have to introduce a new API that can solve this problem.

CC @ilevkivskyi https://github.com/ilevkivskyi (original reviewer), @Tinche https://github.com/Tinche (as you might be interested), @JukkaL https://github.com/JukkaL

— Reply to this email directly, view it on GitHub https://github.com/python/mypy/issues/15515, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOSD4IXND5QV56U552WBVDXNAIF7ANCNFSM6AAAAAAZTCHJII . You are receiving this because you were mentioned.Message ID: @.***>

Tinche avatar Jun 26 '23 19:06 Tinche