mypy icon indicating copy to clipboard operation
mypy copied to clipboard

Change branch name to `main`

Open cdce8p opened this issue 3 years ago • 8 comments

Typeshed just changed the name of the default branch from master to main https://github.com/python/typeshed/issues/8956. With the upcoming 1.0 release (#13685), I think it could make sense to do that for mypy, too.

Github does make it quite easy so we would likely only need to update a few references. Besides that contributors would need to run these commands to update their local copy

git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a

cdce8p avatar Nov 01 '22 23:11 cdce8p

I don't think it's worth it. What's wrong with master? If this is changed, then nothing good will happen, there will only be inconvenience for some contributors.

denballakh avatar Nov 02 '22 08:11 denballakh

Both cpython and typeshed are using main now. I think it will be more consistent.

However, I am not a native english speaker, both of these words mean nothing to me. In my language master is someone who is good at something. So, I don't really care.

sobolevn avatar Nov 02 '22 13:11 sobolevn

The reasons as to why this change of terminology matters are well documented and debated already and shouldn't really need repeating here at this point, for y'all failing to use Google:

  • https://dev.mysql.com/blog-archive/mysql-terminology-updates/
  • https://www.zdnet.com/article/github-to-replace-master-with-alternative-term-to-avoid-slavery-references/
  • https://www.wired.com/story/tech-confronts-use-labels-master-slave/
  • https://www.allaboutcircuits.com/news/how-master-slave-terminology-reexamined-in-electrical-engineering/
  • https://www.drupal.org/project/drupal/issues/2275877
  • https://github.com/django/django/pull/2692
  • https://github.com/bitnami/bitnami-docker-postgresql/issues/175

Yes, this is "just" language, so let's just make the change and get on with our lives. Can we please just learn from where all these discussions have landed, and not repeat them again all over?

antonagestam avatar Nov 09 '22 12:11 antonagestam

I'm fine with changing the branch name to main, but let's wait until 1.0 and any 1.0.x point releases are out to avoid disruption, i.e. let's do it between release cycles. 1.0 should be out within a month or so.

JukkaL avatar Nov 09 '22 12:11 JukkaL

I'm fine with changing the branch name to main, but let's wait until 1.0 and any 1.0.x point releases are out to avoid disruption, i.e. let's do it between release cycles. 1.0 should be out within a month or so.

Maybe now could be a good time to do it. 1.3 has been out for two weeks and it doesn't look like 1.3.1 is necessary. Furthermore, the release-1.4 branch hasn't been cut yet.

Anyhow, the impact should be quite minimal. We'll probably only need to update the branch name in the Github actions workflow files and the readthedocs config. Links should continue to work although we could update these as well, of course.

https://github.com/python/mypy/blob/cbf16658826a1a6372d6bebc298505c67f9fc7bc/.github/workflows/test.yml#L6

cdce8p avatar May 25 '23 12:05 cdce8p

Some other bits:

CREDITS
5:https://github.com/python/mypy/commits/master

README.md
105:python3 -m pip install -U https://github.com/python/mypy/zipball/master

.github/PULL_REQUEST_TEMPLATE.md
7:- Read the [Contributing Guidelines](https://github.com/python/mypy/blob/master/CONTRIBUTING.md)

docs/source/extending_mypy.rst
96:`mypy/plugin.py <https://github.com/python/mypy/blob/master/mypy/plugin.py>`_
98:located in `mypy/plugins <https://github.com/python/mypy/tree/master/mypy/plugins>`_.

mypy/errors.py
1153:        "Please try using mypy master on GitHub:\n"
1162:            "If this issue continues with mypy master, "

mypyc/doc/dev-intro.md
66:the [mypy docs](https://github.com/python/mypy/blob/master/README.md).

hugovk avatar May 25 '23 12:05 hugovk

I opened two PRs to help with the transition

  • [x] #15310 Should be merged before the branch name is changed!
  • [ ] #15311

cdce8p avatar May 26 '23 10:05 cdce8p

I'm fine with changing the branch name to main, but let's wait until 1.0 and any 1.0.x point releases are out to avoid disruption, i.e. let's do it between release cycles. 1.0 should be out within a month or so.

Mypy 1.7 was just released! 🎉

Is now a good time to flip the switch?

hugovk avatar Nov 11 '23 07:11 hugovk

The interest here has died down somewhat. Even with the change being relatively simple, it's probably not worth it at this time to disrupt existing developer workflows.

Might as well consider it at a later point but going to close it for now.

cdce8p avatar Feb 19 '25 21:02 cdce8p

Alternatively, there have been 100 tags of mypy, shall we do it now and get it over with? "Later" often turns into "never".

hugovk avatar Feb 19 '25 21:02 hugovk