mypy icon indicating copy to clipboard operation
mypy copied to clipboard

Release 0.970 planning

Open ilevkivskyi opened this issue 3 years ago • 29 comments

I am planning to make a 0.970 release around mid July (or Jukka may overtake at some point).

Please post here any issues you'd like to see fixed in the release, or PRs you'd like to have merged. There is no release branch yet, but likely I will cut it from some if todays commits. So I would propose to only include critical PRs (e.g. regressions) on top.

ilevkivskyi avatar Jul 08 '22 10:07 ilevkivskyi

Two typeshed things we need to include in the release:

  • https://github.com/python/mypy/issues/13090
  • https://github.com/python/mypy/issues/13091

ilevkivskyi avatar Jul 08 '22 10:07 ilevkivskyi

I'd like to plug my enum PR here:

  • #12963

It fixes a false-positive error that was introduced a few releases back, and it's a very simple fix. It would allow me to correct the typeshed stubs for enum on Python 3.11, which currently aren't quite accurate.

This PR (not by me) purports to fix two open crash reports, and also looks quite simple:

  • #12943

@JukkaL's already reviewed this one (also not by me) and said it was basically ready to go in:

  • #12503

AlexWaygood avatar Jul 08 '22 12:07 AlexWaygood

I have cut the release branch https://github.com/python/mypy/commits/release-0.970 at 9f99400b748a4550813c54fb3f7a00268affdd6d (this includes the above fixes).

ilevkivskyi avatar Jul 08 '22 15:07 ilevkivskyi

I have cut the release branch https://github.com/python/mypy/commits/release-0.970 at 9f99400 (this includes the above fixes).

Awesome, thank you!

AlexWaygood avatar Jul 08 '22 15:07 AlexWaygood

This is a known regression on the 0.970 branch https://github.com/python/mypy/issues/12956 (caused by https://github.com/python/mypy/pull/11143 )

hauntsaninja avatar Jul 08 '22 17:07 hauntsaninja

Also, thoughts on making this the last release to support 3.6? typeshed will be dropping support soon, https://github.com/python/typeshed/issues/6189 is the relevant issue

hauntsaninja avatar Jul 08 '22 18:07 hauntsaninja

Is there a fix for that regression yet? I don't want to delay this release (I want to do it this week). Also don't have any opinion on Python 3.6, @JukkaL what do you think?

ilevkivskyi avatar Jul 11 '22 11:07 ilevkivskyi

(I can confirm that typeshed has now dropped support for 3.6 as of this morning: https://github.com/python/typeshed/pull/8269.)

AlexWaygood avatar Jul 11 '22 11:07 AlexWaygood

Yeah, this will be the last version with full 3.6 support. I think that we can (and should) still continue to maintain Python feature availability checks for 3.6 and earlier.

JukkaL avatar Jul 11 '22 11:07 JukkaL

OK, I can include an announcement in the blog post.

ilevkivskyi avatar Jul 11 '22 11:07 ilevkivskyi

No fix yet for the regression, unfortunately. I'm on vacation, so I won't have the time to fix it soon.

hauntsaninja avatar Jul 11 '22 15:07 hauntsaninja

Would it be possible to have https://github.com/python/typeshed/pull/8295 cherry-picked? It would be annoying to have to wait until the next mypy release, and it's pretty low-risk.

AlexWaygood avatar Jul 15 '22 17:07 AlexWaygood

I'd appreciate if PR #13144 could be cherry-picked. It won't affect the vast majority of users as it only affects mypyc, and it would unblock compilation of Black with latest mypy[c]. We could use mypy[c] from source, but things are simpler if we can pull from PyPI. Thanks in advance! (regardless if it's cherry-picked or not!)

ichard26 avatar Jul 16 '22 14:07 ichard26

Backports for the above mentioned things:

https://github.com/python/mypy/pull/13149 https://github.com/python/mypy/pull/13150 https://github.com/python/mypy/pull/13151

cc @ilevkivskyi

hauntsaninja avatar Jul 16 '22 15:07 hauntsaninja

Merged all three.

ilevkivskyi avatar Jul 16 '22 16:07 ilevkivskyi

Opened a fix for the regression #13161 (regression issue #12956 , regressed by #11143 ) cc @ilevkivskyi

Would love for this to make the release. pandas and django-stubs are starting to use stubtest and they'll get bitten by this if it's regressed in the release.

hauntsaninja avatar Jul 17 '22 01:07 hauntsaninja

Thanks to ethanhs for reviewing! Here's the backport to 0.970 for the fix: #13162

hauntsaninja avatar Jul 17 '22 03:07 hauntsaninja

Since @ilevkivskyi won't be available this week, I will finish the release process.

JukkaL avatar Jul 18 '22 09:07 JukkaL

The wheel builds are broken on macOS, and this is currently blocking the release: https://github.com/mypyc/mypy_mypyc-wheels/actions

#13161 may have broken them, but it's still unclear. If I can't figure out how to fix it soon, I'll try reverting #13161.

cc @hauntsaninja

JukkaL avatar Jul 18 '22 13:07 JukkaL

https://github.com/python/mypy/pull/13161 may have broken them, but it's still unclear.

#13161 caused the wheel build breakage, and the issue can be reproduced locally on macOS: #13174

JukkaL avatar Jul 18 '22 14:07 JukkaL

PR to fix the wheel builds: #13176

Once the wheel builds are fixed, I can make the release. Since I already pushed a commit to update mypy version to 0.970, the released version will actually have to be 0.971.

JukkaL avatar Jul 18 '22 15:07 JukkaL

Mypy 0.971 is out: https://mypy-lang.blogspot.com/2022/07/mypy-0971-released.html

JukkaL avatar Jul 19 '22 15:07 JukkaL

Let's hold off dropping Python 3.6 support until we know that there won't be a bugfix release. We might need 3.6 wheels for the bugfix release still.

JukkaL avatar Jul 19 '22 16:07 JukkaL

When will 0.980 be released? 😀 I was hoping for a newer version of typeshed. Looks like typeshed was picked from 14-Jun-2022, if I'm reading things correctly. I just wanted to voice hope for a 0.980 release with a newer typeshed soon. Thanks.

JohnVillalovos avatar Jul 19 '22 16:07 JohnVillalovos

@JohnVillalovos 0.980 will probably go out around mid August (if things go well). We can't make it earlier due to vacations etc.

JukkaL avatar Jul 19 '22 17:07 JukkaL

https://github.com/python/mypy/issues/13214 is a regression, opened https://github.com/python/mypy/pull/13223 to fix

hauntsaninja avatar Jul 23 '22 06:07 hauntsaninja

potential regression in mypyc: #13227

twoertwein avatar Jul 23 '22 12:07 twoertwein

IIUC it is unlikely someone will fix these soon, so I think it would make sense to not make a point release, the next release should be soon anyway (~mid-August).

ilevkivskyi avatar Jul 27 '22 22:07 ilevkivskyi

Oh, wait, one of them is already fixed. Can we get a fix for the second?

ilevkivskyi avatar Jul 27 '22 22:07 ilevkivskyi

Any more discussion should probably be moved to https://github.com/python/mypy/issues/13385

hauntsaninja avatar Aug 21 '22 04:08 hauntsaninja