miss-islington icon indicating copy to clipboard operation
miss-islington copied to clipboard

Published 20 hours ago • verified publisher icon python

Backport PR with additional commits is not handled yet.

Open Mariatta opened this issue 7 years ago • 2 comments

In https://github.com/python/cpython/pull/5781 miss-islington made the backport PR, however there was an additional commit by a core dev.

That scenario is not yet handled:

  • it did not report the status check result
  • it did not auto-merge

Mariatta avatar Feb 21 '18 17:02 Mariatta

Please don't auto-merge. Commit message created by GitHub for multi-commit PRs is composed from commit messages of both commits. This is not what expected. But preserving the original commit message can be not correct too. An additional commit can introduce semantic changes which should be reflected in commit message. In any case only core developer can make the decision.

serhiy-storchaka avatar Feb 21 '18 17:02 serhiy-storchaka

Ok so it should not auto-merge. It should still report that status checks are complete.

Mariatta avatar Feb 21 '18 18:02 Mariatta