devguide icon indicating copy to clipboard operation
devguide copied to clipboard

Published 20 hours ago • verified publisher icon python

Sect. 3 (Lifecycle of a Pull Request) does not mention Misc/NEWS.d/next and blurb

Open jwuttke opened this issue 3 years ago • 1 comments

The explanations how to create a pull request are incomplete. They should mention

  • That in general a news file is requested.
  • How this file can be generated using blurb.
  • Under which conditions the "skip news" label can be set.

jwuttke avatar Apr 14 '21 19:04 jwuttke

blurb and news entry are described in https://devguide.python.org/committing/#updating-news-and-what-s-new-in-python

Maybe, it's old workflow. Contributor writes patch without news. Core developer commit the patch with news.

In current workflow, we ask contributors to write news entry. So let's move the section from "16. Accepting Pull Requests" to "3. Lifecycle of a Pull Request".

methane avatar Apr 14 '21 22:04 methane