devguide icon indicating copy to clipboard operation
devguide copied to clipboard

Floating << in mobile

Open mariehuynh opened this issue 7 years ago • 10 comments

Shifts around when resizing and scrolling.

mariehuynh avatar May 16 '18 09:05 mariehuynh

Can you share a screenshot?

brettcannon avatar May 16 '18 16:05 brettcannon

https://photos.app.goo.gl/Mab6VutMdXUTH8Ug2

mariehuynh avatar May 16 '18 16:05 mariehuynh

Looks like a French-style quote.

brettcannon avatar May 16 '18 18:05 brettcannon

Probably just a 1-2 line CSS fix. I'll take a look when I get on a real machine.

mariehuynh avatar May 16 '18 18:05 mariehuynh

Hi @mariehuynh, This looks like the sidebar open/close is not rendering properly on Android. I don't see the same behavior on Safari or Chrome when sized to mobile width.

willingc avatar May 17 '18 13:05 willingc

I reproduced the problem on Chromium on Debian, and Chrome on a Mac, by reducing the size of the window and then scrolling horizontally.

mariehuynh avatar May 30 '18 00:05 mariehuynh

I don't see any CSS in this repo that affects this, and traced the problem back to the default CSS in Sphinx. We can override it via something like

div#sidebarbutton span { position: sticky; }

in tools/static/custom.css

mariehuynh avatar May 30 '18 02:05 mariehuynh

Thanks for the research @mariehuynh. I'm glad you were able to reproduce. Your suggestion seems like it will work. We may also see if the fix should be contributed back to the Sphinx project.

willingc avatar Jun 11 '18 01:06 willingc

I can make the change and run some tests. Can you point me at your protocol for testing before submission? What browsers are officially supported?

mariehuynh avatar Jun 11 '18 02:06 mariehuynh

I think it's best to fix this upstream on Sphinx. Once the patch has been tested and accepted upstream we can either apply it here directly, or wait for the next Sphinx release. We also don't have a specific list of supported browsers (other than "the main ones"), but Sphinx might.

ezio-melotti avatar Sep 11 '18 17:09 ezio-melotti

photos.app.goo.gl/Mab6VutMdXUTH8Ug2

Adding that here for future reference:

I've not seen this since we moved to Furo (https://github.com/python/devguide/pull/679), let's close this unless someone can still reproduce.

hugovk avatar Dec 23 '22 08:12 hugovk